Hi,
Just looking at some of our latest commits reminded me of some of the
crazy things that happened to our code base pre-code review. Looking
at the duplication a bit just we have a number of duplicated
interfaces and multiple implementations that are used in a variety of
places

BrokerDetails(one in qpid one in qpid.jms) interfaces and so two
implementations AMQBrokerDetails and BrokerDetailsImp?

We also have THREE URL Parsers:
URLParser (client)
URLParser_0_10 (client)
QpidURL (common) and QpidURLImpl (common)

Is there a reason for this duplication that I'm not aware of?

Can we refactor these classes into single instances. I'm not even sure
we need to have interfaces here.

I can just see this becoming a headache especially as we have a
BrokerDetails interface in the qpid.jms package that we have to
maintain from release to release.

Regards
Martin

-- 
Martin Ritchie

Reply via email to