On Mon, 2008-10-13 at 17:30 -0400, Andrew Stitcher wrote: > This is a classic commit and run! [I'm off for the next couple of days]. > > I've made a change to the FieldTable API to change the inconsistent > getString() and getInt() functions to getAsString()/getAsInt() to better > indicate what they actually do (after a suggestion from Gordon). The > need a different name as they are inconsistent with the other getXXX() > functions. > > I'd argue that they should actually throw an exception if the name-value > pair isn't found, but currently the behaviour is as before (return a > default value). > > I've fixed everything in the qpid C++ tree itself, but this is an > externally visible change that affect other client code as well. > > If necessary it would be trivial to reinstate the old functions as well > and mark them "deprecated", but I decided not to at this stage, if > someone if massively impacted we can do that. > > Regards > > Andrew > >
I'd like to see a set of template <class T> get() functions to make the FT more accessible to templated code. That could be in addition to the plain functions for template-shy compilers/developers. It could be done in a separate FieldTableTraits class, but built-in members would be more convenient.
