I tried to compile 3.1.1 (--with-pam), but the compilation failed in
pop_pass.c:
pop_pass.c:409: warning: initialization from incompatible pointer type
pop_pass.c: In function `auth_user':
pop_pass.c:449: `pname' undeclared (first use in this function)
pop_pass.c:449: (Each undeclared identifier is reported only once
pop_pass.c:449: for each function it appears in.)
make[1]: *** [pop_pass.o] Error 1
It looks like the new code:
/*
* Need to reopen log after calling pam_authenticate, since
* it opens log and sets facility to LOG_AUTH.
*/
closelog();
#ifdef SYSLOG42
openlog ( pname, 0 );
#else
openlog ( pname, POP_LOGOPTS, POP_FACILITY );
#endif
makes use of a global variable (pname) that is defined in main.c only
for standalone.
Changing pname to p->myname fixed the compilation problem.
--Elgin
--- popper/pop_pass.c.pname Fri Nov 3 18:03:40 2000
+++ popper/pop_pass.c Sun Nov 12 12:51:09 2000
@@ -444,9 +444,9 @@
*/
closelog();
#ifdef SYSLOG42
- openlog ( pname, 0 );
+ openlog ( p->myname, 0 );
#else
- openlog ( pname, POP_LOGOPTS, POP_FACILITY );
+ openlog ( p->myname, POP_LOGOPTS, POP_FACILITY );
#endif
DEBUG_LOG2 ( p, "pam_authenticate returned %i; gp_errcode=%i",
