On Mon, Jun 04, 2001 at 09:21:25AM -0400, John MacKenzie - Elehost wrote:
> what does this error mean:
> 
> noop has null function
> 
> just started appearing after we upgraded to 4.02.

With a client that sends a "noop" command periodically (probably to
avoid being timed out) there will be lots of these log entries.  It is
harmless, apart from taking up diskspace in the log.

This is a very minor bug which I didn't get around to looking into
until today, so the fix is not in 4.0.3.

In 4.x, if the state table returns a null function pointer as the
function to execute for a command, the error message "(cmd) has null
function" gets logged on the assumption that this indicates a problem
with the program.  However, since at least 3.0, the "noop" command has
been supported, and the state table entry for it has apparently always
returned a null pointer as an indicator that there is nothing to do for
it.

I think the correct fix is to instead define a noop() function which
does nothing, and have the state table for the noop command return a
pointer to noop().  I'll try to send a patch in soon.

  -- Clifton

-- 
 Clifton Royston  --  LavaNet Systems Architect --  [EMAIL PROTECTED]
   WWJD?   "JWRTFM!" - Scott Dorsey (kludge)   "JWG" - Eddie Aikau

Reply via email to