Author: ask
Date: Thu Feb 14 10:42:54 2008
New Revision: 847
Modified:
trunk/lib/Qpsmtpd.pm
Log:
explain why the CDB config entries are not cached
Modified: trunk/lib/Qpsmtpd.pm
==============================================================================
--- trunk/lib/Qpsmtpd.pm (original)
+++ trunk/lib/Qpsmtpd.pm Thu Feb 14 10:42:54 2008
@@ -178,6 +178,7 @@
my $configfile = "$configdir/$config";
+ # CDB config support really should be moved to a plugin
if ($type and $type eq "map") {
unless (-e $configfile . ".cdb") {
$_config_cache->{$config} = [];
@@ -195,8 +196,9 @@
$self->log(LOGERROR, "tie of $configfile.cdb failed: $!");
return +{};
}
- #warn Data::Dumper->Dump([\%h], [qw(h)]);
- # should we cache this?
+ # We explicitly don't cache cdb entries. The assumption is that
+ # the data is in a CDB file in the first place because there's
+ # lots of data and the cache hit ratio would be low.
return \%h;
}
