Status: Accepted
Owner: pholzer
New issue 29 by pholzer: Qpsmtpd::config caches default value instead of
real value
http://code.google.com/p/smtpd/issues/detail?id=29
What steps will reproduce the problem?
1. Change any configuration setting (via hook_config or get_qmail_config)
for which a default setting exists, e.g., "me" (I used the
config_me_localaddr plugin which sets "me" to conform to the local IP
address of the socket, but it should also be reproducable by setting
/etc/qpsmtpd/me)
2. When config("me") is called the first time, it returns the correct value
but sets the $_config_cache->{me} to the default value
3. When config("me" is called the second time, it returns the cached
default value
4. Visible effect: The hostname in the greeting is correct but the hostname
in the response to EHLO isn't, which may confuse the SMTP client (at least
postfix).
I'm not entirely sure whether caching the result of config is always safe,
but if it does cache it needs to cache the correct value.
I spotted the error in 0.81 (from debian). AFAICS it is still in the
current master. I have a fix for it which I'll publish as soon as I can git
to do what I want :-).
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
