Branch: refs/heads/master
Home: https://github.com/smtpd/qpsmtpd
Commit: 0095e1115863735dc9f8f0a555b5560fd883c2b1
https://github.com/smtpd/qpsmtpd/commit/0095e1115863735dc9f8f0a555b5560fd883c2b1
Author: Jared Johnson <[email protected]>
Date: 2015-01-22 (Thu, 22 Jan 2015)
Changed paths:
M .perltidyrc
Log Message:
-----------
Don't enforce tight parens with perltidy
Revert to default of -pt=1 rather than -pt=2:
> -bt,-pt,-sbt: Container tightness
> These are parameters for controlling the amount of space within containing
> parentheses, braces, and square brackets. The example below shows the effect
> of the three possible values, 0, 1, and 2, for the case of parentheses:
>
> if ( ( my $len_tab = length( $tabstr ) ) > 0 ) { # -pt=0
> if ( ( my $len_tab = length($tabstr) ) > 0 ) { # -pt=1 (default)
> if ((my $len_tab = length($tabstr)) > 0) { # -pt=2
> A value of 0 causes all parens to be padded on the inside with a space, and
> a value of 2 causes this never to happen. With a value of 1, spaces will be
> introduced if the item within is more than a single token.
The tight parens decision was made in 2005 when .perltidyrc was introduced:
https://github.com/smtpd/qpsmtpd/commit/2535e772939f9f5f88aba016168d76e0e3abeac5
I tried pretty hard but couldn't find any previous discussion about this
decision, I'm not quite sure who supported it, who cared about it at all,
or who knew about it at all.
What I know is that I like pt=1 better. Nobody ever gets what they want
if they don't ask :)
Commit: cfce4e44d0183a20389707287b5937ee3ed7edcf
https://github.com/smtpd/qpsmtpd/commit/cfce4e44d0183a20389707287b5937ee3ed7edcf
Author: Matt Simerson <[email protected]>
Date: 2015-01-27 (Tue, 27 Jan 2015)
Changed paths:
M .perltidyrc
Log Message:
-----------
Merge pull request #201 from jaredj/default-parens
Don't enforce tight parens with perltidy
Compare: https://github.com/smtpd/qpsmtpd/compare/343a7ee68617...cfce4e44d018
