PATCH: <> rejected by require_resolvable_fromhost

[Brian Grossman]

Qpsmtpd/SMTP.pm uses Mail::Address->new incorrectly.  This causes
plugins/require_resolvable_fromhost to reject mail from <> because
$sender->format() resolves to '"<>"' (as in length('"<>"')==4).

This is with qpsmtpd from cvs and with Mail::Address v1.59 and v1.60.

I don't see the problem when talking to perl.org MX ran.mx.develooper.com.
Does perl.org not use the require_resolvable_fromhost plugin?

Patch below.

Brian


--- qpsmtpd-cvs/lib/Qpsmtpd/SMTP.pm-orig        Sun Nov 23 17:02:15 2003
+++ qpsmtpd-cvs/lib/Qpsmtpd/SMTP.pm     Sun Nov 23 17:02:45 2003
@@ -209,7 +209,7 @@
     my ($from) = ($from_parameter =~ m/^from:\s*(\S+)/i)[0];
     warn "$$ from email address : [$from]\n";
     if ($from eq "<>" or $from =~ m/\[undefined\]/) {
-      $from = Mail::Address->new("<>");
+      $from = Mail::Address->new('', "<>");
     } 
     else {
       $from = (Mail::Address->parse($from))[0];