I add a block like the following to the plugins that I want whitelisting
honored in:
# return if whitelisted
return (DECLINED) if $transaction->notes('whitelisthost');
return (DECLINED) if $transaction->notes('whitelistclient');
return (DECLINED) if $transaction->notes('whitelisthelo');
return (DECLINED) if $transaction->notes('whitelistsender');
return (DECLINED) if $transaction->notes('whitelistrcpt');
I do this for most of the plugins that I use. I do not do it for the clamav
plugin since I want that one to run regardless of the whitelisting status.
Chris
> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> Sent: Sunday, February 29, 2004 1:40 PM
> To: qpsmtpd ML
> Subject: "return OK ;"
>
> Hmm. This doesn't seem to be working properly for me right now.
>
> I was testing Robert James Kaes' check_goodrcptto and a modified
> version of Devin Carraway's whitelist plugins, and determined
> that even
> though both returned "OK", that did not prevent any of the plugins
> following them in the config/plugins list from running.
>
> I have the 0.26 version of the qpsmtpd package installed, and I
> have modified things to allow DENYHARD. (Downloaded, not CVS.)
>
> I note that in the Qpsmtpd.pm file, the run_hooks subroutine
> contains a comment asking if we should have a hook for "OK".
> I also note
> that the SMTP.pm file contains three tests that look
> specifically for (or
> include) "OK" in what they test.
>
> While I suspect I could use something like Devin's:
>
> return OK if $transaction->notes('whitelist');
>
> ...in every plugin, I don't think that that is what's actually
> intended.
>
> The README.plugin implies, though it is not clear, that
> "OK" might
> pertain only to other plugins in the same hook.
>
> Can anyone comment or provide pointers? Thanks.
>
> --
> Roger Walker
> "HIS Pain - OUR Gain"
>
>