Is there a reason that qpsmtpd replies 552 on DENY's rather than 554?
I'm not a smtp guru but what I can derive from rfc0822 is that a 554 (Transaction Failed) response would be more appropriate than a 552 (Requested mail action aborted: exceeded storage allocation).
If nobody knows of any reason, please accept my diff's to correct this problem.
Thanks, Eric Smoker
--- lib/Qpsmtpd/SMTP.pm 2004-03-08 16:27:02.000000000 -0000
+++ cvs/lib/Qpsmtpd/SMTP.pm 2004-03-05 12:46:23.000000000 -0000
@@ -422,7 +422,7 @@
return 1;
}
elsif ($rc == DENY) {
- $self->respond(554, $msg || "Message denied");
+ $self->respond(552, $msg || "Message denied");
}
elsif ($rc == DENYSOFT) {
$self->respond(452, $msg || "Message denied temporarily");
@@ -447,7 +447,7 @@
$self->respond(250, ($msg || 'Queued'));
}
elsif ($rc == DENY) {
- $self->respond(554, $msg || "Message denied");
+ $self->respond(552, $msg || "Message denied");
}
elsif ($rc == DENYSOFT) {
$self->respond(452, $msg || "Message denied temporarily");
--- lib/Qpsmtpd/SelectServer.pm 2004-03-08 16:26:09.000000000 -0000
+++ cvs/lib/Qpsmtpd/SelectServer.pm 2004-03-05 12:46:23.000000000 -0000
@@ -268,7 +268,7 @@
return 1;
}
elsif ($rc == DENY) {
- $self->respond(554, $msg || "Message denied");
+ $self->respond(552, $msg || "Message denied");
}
elsif ($rc == DENYSOFT) {
$self->respond(452, $msg || "Message denied temporarily");
