Michael Holzt wrote:
In my opinion the current practice of dynamically adding the "AUTH" keyword
to the list of understood commands in the ehlo-Subroutine of SMTP.pm is bad
design. Why? Because the current design requires changes in SMTP.pm for every new SMTP extension and every new command.
It's the only way to do it now and I needed this to work _now_, not some time in the [possibly distant] future. Sure it would be nice to be able to dynamically define permissible commands, but it isn't there now.
I'm not sure why the Auth.pm Module is part of the qpsmtpd Core anyway. Why
not implement SMTP extensions in a way similar to plugins?
Patches welcome? It shouldn't be too hard to extend the current code to be more generic on extensions; but it is still going to involve poking into the hash of {_commands} since that is where qmsmtpd stores it's list. However, one thing to ask before you start is what other extensions are widely implemented and would be nice to have around (I can only think of one, starttls, and I don't know how well that would translate to working as a plugin since it is almost like a new transaction).
John
