> I posted a patch to require_resolvable_fromhost a month or so ago, which > had that useless (IMHO) check removed. It also performed it's DNS lookups > in the background, allowed IPv4 and IPv6 address literals, caught > private/local address literals and DNS lookups. For some reason it didn't > make it into CVS.
The plugin is a little _too_ strict. I think it might want to be a separate plugin like 'require_valid_fromhost'. People might be running qpsmtpd on their internal network, or with a relay. By keeping rrfh simple, we maintain flexibility. Some random comments: - You define the RRF_ constants and never use them. - Your ipv6 checks allow more than hex digits - i don't see how 2821 sets domain compliance. if you're going to quote a RFC, might as well specify a section.
