On 5 Sep 2004, at 15:08, Matt Sergeant wrote:
On 5 Sep 2004, at 13:52, John Peacock wrote:
Matt Sergeant wrote:I think that may be my fault, by moving the global hooks hash into the qpsmtpd object. But I think we definitely want to keep that change, so we'll fix it if its broken instead of backing it out.
Yeah, those are the changes I backed out and it started working again. You are right, though, that the global hash belongs in the object instead, so we'll need to fix it.
I honestly thought I'd tested it and it worked, so I'll look at it a bit more today.
OK, fixed, and I added a stub Makefile.PL that we can add to, and MANIFEST (& .SKIP) files.
The fix isn't entirely efficient - every time we new() a Qpsmtpd object we have to now register all the plugins in that object. I doubt that will be much in the way of overhead, but we might want to keep an eye on it.
Matt.
