This looks great to me, but I'd like to quibble about the plugin names. To
me a check plugin does a check takes some action, if appropriate, which usually means returning an OK or DENY (or DECLINED, of course). Your check_finger is a good example. So I'd prefer your #4 to be called check_relay
(or perhaps check_rcpthosts or something similar), and your #1 to be something
different, not a check_ plugin. How about set_relay_client or something?
I'm inclined to leave them as I originally discussed, with this explanation:
1) check_relay is really the same plugin as it was before: it /check/s that the remote IP can /relay/ through the server. It just occurs at an earlier phase of the connection and it no longer does the unrelated bits to see if the domain is local.
4) The reason I chose rcpt_ok is that in most cases, by the time this plugin is running, the RCPT has not been explicitly blocked and so if it is local it should be OK. Think of it like a select statement; each special test has it's own CASE, but the fallback is DEFAULT. I like that rcpt_ok is named different from the other check_* plugins; it calls attention to the fact that something special is happening here...
John
