On 15 Mar 2005, at 06:42, John Peacock wrote:
I'm sorry, I should have made clear that from the caller's perspective, nothing changes, so we don't have to change any call to $self->log(). See the attached patch for an example implementation (which nicely indents the related log entries as a side effect).
Hmm. I'm not entirely happy that the API is different depending on where you're calling ->log from. Are there plugins out there that call $self->qp->log()? I think there might be.
It just feels a little hackish to me to differentiate how it works depending on number of parameters. Wouldn't we be better with separate ->log methods for internal functions and leave the generic ->log() method as it is now for plugins to call?
Matt.
