A few quick comments on the taint check thing:

1) The taint check was (partially) added because it's a giant pain to add later. Remove it is easy, adding it is hard. Maybe just turning it off is the right answer.

2) It's mostly (only?) useful to keep things coming from the network "in check".

3) Adding some "check/conform/validate the configuration" feature to the config interface might be useful if it's optional, but I don't think it should be done "because of taint".

4) If someone adds a config plugin that gets some of the configuration from "untrusted" sources, that plugin should check it for Evil Values I think. Maybe by plugging into the "check the value" option if that is added. :-)

5) Options to the config thing should be a hashref; how the map/cdb option is implemented now is bad and ugly.


- ask

ps. Elliot: Sorry about the mild case of bikeshedding[1] here; I'm hoping John (or someone else with more AUTH and LDAP experience than me) will review and commit or send back comments on the auth plugin. :)

[1] http://xrl.us/fq5j (Link to www.freebsd.org)


-- http://www.askbjoernhansen.com/



Reply via email to