On 2005-04-25 21:47:21 +0200, Peter J. Holzer wrote: > On 2005-04-25 11:02:41 -0400, John Peacock wrote: > > Peter J. Holzer wrote: > > >For small values of "sort of", yes. It must be called after register (of > > >course), so it would actually be called from Qpsmtpd::TcpServer::run. > > >It would probably make sense to move loading the plugins to qpsmtpd and > > >Apache::Qpsmtpd respectively. > > > > It would probably be simpler to move the load_plugins() call into > > Qpsmtpd::TcpServer->new() since that is the first time it is possible to > > load the plugins themselves (you need an object to store the hooks in). > > Yes, you are right. That seems to be the most logical place.
I really should run "make test" more often. This breaks t/plugin_tests.t
because now $self->{_test_mode} is set too late. Not a big problem,
though - just add a _test_mode parameter to Qpsmtpd::SMTP->new().
hp
--
_ | Peter J. Holzer | Weil wir die materielle Welt nicht so
|_|_) | Sysadmin WSR | wahrnehmen, wie sie ist, sind Sachen wie
| | | [EMAIL PROTECTED] | JPEG, MP3 usw. m�glich.
__/ | http://www.hjp.at/ | -- Heiko Schlenker in drsm.
pgpDpOTr5J6Nh.pgp
Description: PGP signature
