Re: PATCH: high_perf: socket timeouts

[Brian Grossman]

On Mon, 9 May 2005 09:35:26 -0400
Matt Sergeant <[EMAIL PROTECTED]> wrote:

> On 9 May 2005, at 00:29, Brian Grossman wrote:
> 
> > Attached is a patch implementing a kludge to fix this.  Does anyone 
> > see a
> > cleaner way to do this?
> 
> Yup, I'm applying a patch now for this (along with all your other stuff 
> with minor modifications).

Ah, yes.  I like yours much better than mine.

However, when I merged your changes back into my local branch, I started
getting errors like:

        Can't call method "can" on an undefined value at 
.../lib/Danga/Socket.pm line 281.

I haven't isolated the cause yet, but the attached kludge alleviates the
symptom for me.


Brian

--- lib/Danga/Socket.pm 2005-05-09 13:17:47.000000000 -0600
+++ lib/Danga/Socket.pm 2005-05-09 14:42:47.000000000 -0600
@@ -278,6 +278,7 @@
         
         foreach my $fd ( keys %DescriptorMap ) {
             my Danga::Socket $sock = $DescriptorMap{$fd};
+            next if !defined $sock;
             if ($sock->can('ticker')) {
                 $sock->ticker;
             }