On Tue, 10 May 2005 17:04:20 -0400
Matt Sergeant <[EMAIL PROTECTED]> wrote:
> On 7 May 2005, at 18:08, Brian Grossman wrote:
>
> > PostLoopCallback was a global and would be overwritten by anyone with
> > an
> > interest. This caused a race condition. For example,
> > check_earlytalker
> > would fail horribly if there was more than one connection.
>
> Although I applied this patch I'm confused about one aspect that I'm
> thinking of reverting. You change the close call to push both the self
> and sock onto @ToClose and then set the ->{closing} flag to zero.
>
> I don't see a reason to do this. Why did you make that change?
Honestly, I don't remember. I think have_line was returning 0 when there
was a new line available and causing an error elsewhere. It was probably
before I figured out where the real race was.
I'm running without the closing=0 line right now and I don't see any ill
effects. I'd say revert it and I'll send in another patch with an
explanation if it crops up again.
Brian
