Marco Aurelio Monteiro wrote:
I found a problem related to TLS and check_relay plugins. After the
starttls command the server responds "relaying denied". Check_relay
plugin is configured properly.
Check_relay plugin sets to 1 a variable of $connection called
relay_client, however it is not saved in the tls plugin.
There is a patch attached. Please take a very good look at this,
because I am starting with qpsmtpd.
The code was downloaded from svn and the revision is 519.
Thanks
------------------------------------------------------------------------
--- tls.orig Wed Jul 20 14:29:40 2005
+++ tls Wed Jul 20 14:30:17 2005
@@ -92,7 +92,7 @@
my $conn = $self->connection;
# Create a new connection object with subset of information collected
thus far
my $newconn = Qpsmtpd::Connection->new();
- for (qw(local_ip local_port remote_ip remote_port remote_host
remote_info)) {
+ for (qw(local_ip local_port remote_ip remote_port remote_host
remote_info relay_client)) {
$newconn->$_($conn->$_());
}
$self->qp->connection($newconn);
You found the bug, but to make sure something else is not
lost, it may be better to clone the old object, create the new
object, pretend(bless?) the old object as the new object and
copy a small set of known required values from the new
object into the merge object. I think John may have told a
few people to make notes in the connection object if they
want to make sure they don't get lost, instead of the
transaction object, do I remember that? We don't know
exactly what's in the attic then.
-Bob
