On 2005-10-17 22:24:18 +0200, Peter J. Holzer wrote: > On 2005-10-17 12:52:56 -0400, John Peacock wrote: > > Hanno Hecker wrote: > > >If you want to use something like virtual_alias_domains > > >the CLEANUP_FLAG_MAP_OK is required. > > > > Can someone who uses Postfix confirm that this fix works? > > I will have a look at it when I have time (hopefully tomorrow evening).
Sorry this took so long.
> I originally wrote the plugin for postfix 1.x, and I don't remember if I
> didn't set any flags on purpose or if those flags were only added with
> postfix 2.x.
Postfix 2.2 knows about the following flags:
#define CLEANUP_FLAG_NONE 0 /* No special features */
#define CLEANUP_FLAG_BOUNCE (1<<0) /* Bounce bad messages */
#define CLEANUP_FLAG_FILTER (1<<1) /* Enable content filter */
#define CLEANUP_FLAG_HOLD (1<<2) /* Place message on hold */
#define CLEANUP_FLAG_DISCARD (1<<3) /* Discard message silently */
#define CLEANUP_FLAG_BCC_OK (1<<4) /* Ok to add auto-BCC addresses */
#define CLEANUP_FLAG_MAP_OK (1<<5) /* Ok to map addresses */
Postfix 1.1 only knew the first two. According to my notes I disabled
CLEANUP_FLAG_BOUNCE on purpose and was unsure whether
CLEANUP_FLAG_FILTER should be enabled.
I agree with Hanno that CLEANUP_FLAG_MAP_OK should be set.
Setting CLEANUP_FLAG_FILTER and CLEANUP_FLAG_BCC_OK may be ok, too.
Personally I would prefer to perform equivalent actions in
qpsmtpd-plugins, but in some cases it may be useful to leave these to
postfix. Anyway, I can't see any harm in setting them, so right now I'd
lean to replacing the line with
$strm->print_attr('flags' => 0x32);
(the leading zeros were unnecessary). I still have to test whether these
flags have any unexpected side effects, so for now please apply Hanno's
patch.
(Another idea would of course be to make the flags configurable)
hp
--
_ | Peter J. Holzer | Ich sehe nun ein, dass Computer wenig
|_|_) | Sysadmin WSR | geeignet sind, um sich was zu merken.
| | | [EMAIL PROTECTED] |
__/ | http://www.hjp.at/ | -- Holger Lembke in dan-am
pgp5366hHLrhU.pgp
Description: PGP signature
