Brian Szymanski wrote:
> The problem is this: $mechanism has been made lowercase, and keys of
> %auth_mechanisms have all been made uppercase.
I swear that I tested this, but I had two different changes in my working copy
and I backed out both and applied one at a time, so I may have tested something
very slightly different than what I committed. I chose to always uppercase the
$mechanism; it makes no sense to lowercase it at the top and then uppercase it
later when testing.
=== lib/Qpsmtpd/SMTP.pm
==================================================================
--- lib/Qpsmtpd/SMTP.pm (revision 852)
+++ lib/Qpsmtpd/SMTP.pm (revision 853)
@@ -243,7 +243,7 @@
return $self->respond(501, $mechanism || "Syntax error in command")
unless ($ok == OK);
- $mechanism = lc($mechanism);
+ $mechanism = uc($mechanism);
#they AUTH'd once already
John
p.s. the other bit I wound up committing "by accident" was a more conservative
way of dealing with "Incomplete DATA" or "Message too big" errors. I'll tweak
the log entry...
