On 11/1/06 4:44 AM, "Ask Bjørn Hansen" <[EMAIL PROTECTED]> wrote:
> > On Oct 24, 2006, at 8:43 AM, Peter Eisch wrote: > >> When the plugin was changed to use the qpsmtp transaction temp >> file, this >> broke the tmp_dir option. The patch below fixes this bug [....] > [ ... http://beta.nntp.perl.org/group/perl.qpsmtpd/5681 ...] > > Hi Peter, > > I don't understand how the patch fixed the tmp_dir option. Unless > I'm missing something then you just made the option required (and > removed the sanity checking (directory exists)). > > FWIW I agree with John that it'd be better to make Qpsmtpd::temp_ > {file,dir} take a path parameter. > If you're using the qpsmtpd's spool_dir it is more than likely safe to assume that the sanity check is done long before it gets used in a plug-in. I'll redo the patch with John's suggestion. I have it scoped but I haven't been able to get it implemented due to a conversion. I did get to wonder if the parameter is actually ever practical if the message is already constituted as a file if the permissions are properly set. I seem to think that I started using the parameter in order to work through permissions. I hope to wrap this up this weekend. epter
