David Sparks wrote:

(as a side note I have another speedup coming for you shortly - I have re-written the DNS resolver in XS, which should provide a significant speedup).

Sweet, I haven't looked too closely at whats going on, but %INC suggests that PollServer still uses Net::DNS for something. Will this dependency be going away?

Probably not - the way I've coded it right now it'll still load Net::DNS, just not use it. Do you need the dependency to go away?

Bug. Try this patch:

Thanks, that seems to work.

OK, I'll apply next week unless someone else can do it. I'm in the UK this week so it's a bit harder to work on qpsmtpd.

Overall it seems really bizarre (to me at least) to be "fixing up" the raw protocol such that a non-overridable, default protocol handler will do what you want. Did anyone ever propose a hook_rcpt_raw() that would be called with the unverified line (supporting the same return codes as hook_rcpt)? This would give plugin authors a choice of working with rfc-compliant data, or the raw data if they wanted to do their own checking, or perhaps other uses like trying to fingerprint the sender.

One thing I don't want to end up doing is having too many hooks... More hooks makes everything slower. But I may be in a weird situation (using qpsmtpd as a very high performance smtpd) compared to others.

Matt.

Reply via email to