On Sun May 04, 2008 at 21:21:03 -0400, Matt Sergeant wrote:
> --- plugins/tls (revision 876)
> +++ plugins/tls (working copy)
> @@ -150,7 +150,7 @@
> return DECLINED unless $local_port == 465; # SMTPS
>
> unless ( _convert_to_ssl($self) ) {
> - return (DENY_DISCONNECT, "Cannot establish SSL session");
> + return (DENY_DISCONNECT, "Cannot establish SSL session");
Seeing changes like this makes me wonder if we should consider running
all source through perltidy at some point. Perhaps as part of a
"make update", or "make commit" target.
ObRelated: I would be happy to submit a patch to unify plugin
argument names. I see big differences between:
./queue/exim-bsmtp: my ( $self, $txn ) = @_;
./logging/file: my ( $self, $txn ) = @_;
And:
./virus/clamav: my ( $self, $transaction ) = @_;
./valid_users: my ( $self, $transaction, $sender, %param ) = @_;
For example. I'd suggest s/txn/transaction/g on all plugins
shipped with the core distribution, because I think the verbosity
and consistency wouldn't be a bad thing.
Steve
--
Managed Anti-Spam Service
http://mail-scanning.com/
