Hi Phil,
in an attempt to build QScintilla 2.8 in the usual way¹, I noticed some
issues. I was able to fix some of them with the attached patches, but
failed on this one:
[ 58s] g++ -c -pipe -fmessage-length=0 -grecord-gcc-switches -O2 -Wall
-D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
-fasynchronous-unwind-tables -g -DUSE_LIB64_PATHES -fno-strict-aliasing -w
-fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2
-fstack-protector -funwind-tables -fasynchronous-unwind-tables -g
-DUSE_LIB64_PATHES -fno-strict-aliasing -D_REENTRANT -fPIC
-DQSCINTILLA_MAKE_DLL -DSCINTILLA_QT -DSCI_LEXER -DQT_NO_DEBUG
-DQT_THREAD_SUPPORT -DQT_SHARED -DQT_TABLET_SUPPORT
-I/usr/lib/qt3/mkspecs/default -I. -I. -I../include -I../lexlib -I../src
-I/usr/include -I/usr/lib/qt3/include -o LexAPDL.o ../lexers/LexAPDL.cpp
[ 58s] In file included from ScintillaQt.h:64:0,
[ 58s] from ScintillaQt.cpp:38:
[ 58s] ../src/Editor.h: In member function 'QString
QsciScintillaQt::textRange(const SelectionText*) const':
[ 58s] ../src/Editor.h:81:14: error: 'std::string SelectionText::s' is private
[ 58s] std::string s;
[ 58s] ^
[ 58s] ScintillaQt.cpp:425:16: error: within this context
[ 58s] if (!text->s)
[ 58s] ^
[ 58s] ScintillaQt.cpp:425:9: error: no match for 'operator!' (operand type
is 'const string {aka const std::basic_string<char>}')
[ 58s] if (!text->s)
[ 58s] ^
[ 58s] ScintillaQt.cpp:425:9: note: candidate is:
[ 58s] ScintillaQt.cpp:425:9: note: operator!(bool) <built-in>
[ 58s] ScintillaQt.cpp:425:9: note: no known conversion for argument 1 from
'const string {aka const std::basic_string<char>}' to 'bool'
[ 58s] make: *** [ScintillaQt.o] Error 1
It might bail on some other lexer, though.
Any idea?
BTW: it would be nice to NOT abandon the Qt3 builds right away, please ;-)..
Thanks & cheers,
Pete
¹)
https://build.opensuse.org/package/live_build_log/home:frispete:PyQt/qscintilla/openSUSE_13.1/i586
Index: b/Qt3/MacPasteboardMime.cpp
===================================================================
--- a/Qt3/MacPasteboardMime.cpp
+++ b/Qt3/MacPasteboardMime.cpp
@@ -25,7 +25,7 @@
// WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
-#include <QtGlobal>
+#include <qglobal.h>
#if defined(Q_OS_MAC)
#if (QT_VERSION >= 0x040200 && QT_VERSION < 0x050000) || QT_VERSION >= 0x050200
Index: b/Qt3/ScintillaQt.h
===================================================================
--- a/Qt3/ScintillaQt.h
+++ b/Qt3/ScintillaQt.h
@@ -26,7 +26,6 @@
#ifndef SCINTILLAQT_H
#define SCINTILLAQT_H
-
#include <qtimer.h>
#include <qclipboard.h>
@@ -36,6 +35,8 @@
// These are needed because Scintilla class header files don't manage their own
// dependencies properly.
+#include <string>
+#include <algorithm> // use algorithms replace
#include <vector>
#include <assert.h>
#include <ctype.h>
Index: b/Qt4Qt5/ScintillaQt.h
===================================================================
--- a/Qt4Qt5/ScintillaQt.h
+++ b/Qt4Qt5/ScintillaQt.h
@@ -26,7 +26,6 @@
#ifndef SCINTILLAQT_H
#define SCINTILLAQT_H
-
#include <qtimer.h>
#include <qclipboard.h>
@@ -36,6 +35,8 @@
// These are needed because Scintilla class header files don't manage their own
// dependencies properly.
+#include <string>
+#include <algorithm> // use algorithms replace
#include <assert.h>
#include <ctype.h>
#include <stdlib.h>
_______________________________________________
QScintilla mailing list
[email protected]
http://www.riverbankcomputing.com/mailman/listinfo/qscintilla
