Hi,

I have a couple of comments related to the TextField echoMode property:

> we discussed this quite a bit today and came to a conclusion to turn
> into an enum, instead of bool:
> 
> enum echoMode { Normal, Password }
...
> the qml TextInput also has a echoMode { Normal, Password, NoEcho,
> PasswordEchoOnEdit }, so
> this difference for the TextField is that the Password case will show
> the last letter while entering
> text (actually more close to what TextInput:PasswordEchoOnEdit is).

1. Could it be confusing to some developers that TextInput has a property with 
exactly the same name "echoMode", but with different enumeration values, 
especially when Password is specified differently (as described in quoted 
text)? On the other hand the suggested enumeration is so simple that confusion 
may not be a problem :-)

2. What would be the enum type for TextField's echoMode, taking into account 
QML's limited support for enums (QTBUG-14861, QTBUG-15483, QTBUG-15484)? My 
understanding is that the property itself needs to be of type int like it is in 
QTCOMPONENTS-200 currently. But how about the actual values? If implementing 
TextField in QML, the underlying enumeration probably needs to be registered 
with some unique type, e.g. TextFieldEchoMode (i.e. it can't be referred like 
"TextField.Password"). Reusing TextInput's EchoMode values doesn't sound like a 
good idea either (unless TextInput's echoMode property is aliased as such). I 
think these details should also be specified in the common API.

BR,
Taneli
_______________________________________________
Qt-components mailing list
Qt-components@qt.nokia.com
http://lists.qt.nokia.com/mailman/listinfo/qt-components

Reply via email to