Uhhh.. Its not very trivial but I create code review: https://codereview.qt-project.org/#change,66573 :-)
Also, I forget rebase my changes into one commit and create two wrong reviews: https://codereview.qt-project.org/#change,66570 https://codereview.qt-project.org/#change,66571 Is it possible to destroy them? 2013/9/10 Orgad Shaneh <org...@gmail.com> > On Tue, Sep 10, 2013 at 11:52 AM, hatred <adrozd...@gmail.com> wrote: > >> Hi Tobias, >> >> Heh... I don't have access to the global git repos via ssh & git >> protocols, so I can't clone repo from codereview.qt-project.org :-( Can >> code review tool assept changes via e-mail (git format-patch ..., git >> send-email)? >> >> >> 2013/9/10 Tobias Hunger <tobias.hun...@gmail.com> >> >>> >>> On Sep 10, 2013 8:48 AM, "hatred" <adrozd...@gmail.com> wrote: >>> > So I prepare patch that helps me to work with perforce and fix >>> top-level directory detection issue: http://pastebin.com/TE8Vey54 >>> >>> Hey, thanks for investigating! >>> >>> Unfortunately I can only accept contributions that are sent in via >>> https://codereview.qt-project.org/ >>> >>> I would appreciate if you could go through the setup there and send the >>> patch via the review system. >>> >>> Thanks! >>> >>> > I also attach it to this letter. >>> > >>> > This patch based on the latest 2.8 branch (2013-09-10). >>> > >>> > Can any body create issue on tracker and attach this patch? >>> >>> No, for this patch to get accepted you have to push it into codereview >>> (aka credit). We may not use the code otherwise. >>> >>> Best Regards, >>> Tobias >>> >> >> >> _______________________________________________ >> Qt-creator mailing list >> Qt-creator@qt-project.org >> http://lists.qt-project.org/mailman/listinfo/qt-creator >> >> > Try using ssh.qt-project.org. See > here<http://qt-project.org/wiki/Setting-up-Gerrit#0c65d88ba55f29fbaf09826efcc59efa> > . > > - Orgad >
_______________________________________________ Qt-creator mailing list Qt-creator@qt-project.org http://lists.qt-project.org/mailman/listinfo/qt-creator
