On 01/27/2014 07:57 AM, Petar Perisin wrote:
Strongly agree too.
I did not like first time I got -1, and still now I'm reluctant to
give someone -1 just because of "I would prefer you did not submit
this". To me this sounds like "I wish you did not do any work
regarding this at all, you incompetent ... something". It's really bad
- I would not want to say it to anyone.
"I feel that this requires additional work before it is merged." -
sounds like really nice for -1. This kind of text would not make me
feel bad when giving -1 any more.
Regards,
Petar
+1
On Sun, Jan 26, 2014 at 10:43 PM, Coda Highland <[email protected]
<mailto:[email protected]>> wrote:
On Sun, Jan 26, 2014 at 1:13 PM, Cristian Tibirna <[email protected]
<mailto:[email protected]>> wrote:
> On Sunday 26 January 2014 10:06:37 Orgad Shaneh wrote:
>> Hi,
>>
>> Following this
>>
discussion<http://lists.qt-project.org/pipermail/qt-creator/2012-December/0
>> 01718.html>from about a year ago,
>>
>> gerrit has recently accepted a wording
>> change<https://gerrit-review.googlesource.com/54000>for default
-1 and
>> -2 Code-Review labels.
>>
>> The scores are now:
>> -1 - I would prefer this is not merged as is
>> -2 - This shall not be merged
>>
>> I suggest configuring qt-project gerrit to something similar.
>>
>> Opinions?
>
> Strongly agree:
>
http://lists.qt-project.org/pipermail/qt-creator/2012-December/001718.html
>
> As Guido observes, this is still not ideal, but it is much
better than the
> current.
Like the suggestion in the first post of the old thread, I am of the
opinion that the message should speak somewhat more to a generic means
of resolution:
"I feel that this requires additional work before it is merged."
This is non-offensive, sounds subjective instead of authoritative,
avoids "you"-language, and clearly indicates that it's still possible
to be included -- just not like it is.
/s/ Adam
_______________________________________________
Qt-creator mailing list
[email protected] <mailto:[email protected]>
http://lists.qt-project.org/mailman/listinfo/qt-creator
_______________________________________________
Qt-creator mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/qt-creator
_______________________________________________
Qt-creator mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/qt-creator
