Hi Marc,
either you already know who is responsible for a module or you just do
the simple way:
Do a git blame on the files you changed and see who worked most or
recently on it. That's the way I do if I submit a patch and I think most
other do it the same way.
Best regards,
André
Am 23.06.2016 um 09:57 schrieb Marc Reilly:
Hi All,
How do I find/determine who is best/able to review code, and is it
considered impolite to just add people as reviewers?
I have a series which is similar to another which one which was
previously accepted, so I would start will those people, but it seems
kinda rude to just add everyone en-masse.
Anyway, if anyone is interested, I've implemented a hover handler which
will preview images from .qrc files when mouse hovers over a
"qrc:/file/image.png" bit of text. At the moment it is just for cpp files..
The series is 4 commits, and starts with:
https://codereview.qt-project.org/#/c/158305/
Cheers,
Marc
(FWIW, i'm happy for anyone to add me as a reviewer)
_______________________________________________
Qt-creator mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/qt-creator
_______________________________________________
Qt-creator mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/qt-creator
