It looks like this crash was occurring because NP_GetEntryPoints was being called before NP_Initialize.

The following patch fixes the problem.

Attachment: 4.5-tp1.src.3rdpart.webkit.WebCore.plugins.mac.PluginPackageManager.cpp.patch
Description: Binary data




It basically moves the NP_GetEntryPoints call to after the NP_Initialize call and only does it in the conditional case where the m_browserFuncs struct was not already passed to the NP_Initialize. (These two options seem to be mutually exlusive).

Again, if someone with more knowledge of NSAPI and WebKit could confirm this patch (and my previous patch), that would be greatly appreciated. I hope to see this patch along with my previous patch in the next Qt 4.5 release, and I'll leave it to guys to propagate it back upstream to WebKit.

On Oct 23, 2008, at 11:36 AM, Peter Johnson wrote:

With Qt 4.5 tp1, Qt apps, including the sample web browser from the
qtdemo, will crash if some plugins are present.  I have noticed this
with the Move Networks plugin (http://www.movenetworks.com/) and the
Microsoft Silverlight plugin.

I have confirmed this on Mac OS X 10.4.11 and Mac OS X 10.5.4.

Here is a backtrace:

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_PROTECTION_FAILURE at address: 0x00000008
0x140794b3 in NP_Initialize ()
(gdb) bt
#0  0x140794b3 in NP_Initialize ()
#1  0x1406ff47 in NP_GetEntryPoints ()
#2  0x01827a89 in WebCore::PluginPackage::load ()
#3  0x0182827f in WebCore::PluginPackage::fetchInfo ()

_______________________________________________
Qt4-preview-feedback mailing list
[email protected]
http://lists.trolltech.com/mailman/listinfo/qt4-preview-feedback

Reply via email to