On Monday 02 February 2009 13:02:34 Marcel Partap wrote: > Hi, > kdiff3 is a tool i regularly use to compare folder hierarchies, but > what always troubled me a bit was the performance issues when > traversing the tree or showing/hiding a subset of items (equal, > orphans in A/B).. when i did a valgrind --tool=callgrind run on it > yesterday i finally saw where all this time is spent - within the > QTreeWidget::isItemHidden function! That is maintaining a list of > hidden items and traverses that each and every time to find out wheter > an individual item actually is hidden. Comparing two folder > hierarchies with a total of ~8000 items thus results in over 150 > million iterations within that loop! The simple hack which is attached > obviously cut that down massively, but i'm not sure wether it might > break any functionality that is provided by iterating over that list.. > Does it? > rgds marcel.
Hi, Which version of Qt did you use? It seems that you used Qt 4.4. Because this problem should already been solved in Qt 4.5 Thanks for your patch anyway. -- Olivier _______________________________________________ Qt4-preview-feedback mailing list [email protected] http://lists.trolltech.com/mailman/listinfo/qt4-preview-feedback
