Hi,
I've recently had the opportunity to use QXmlSchema for a short while, here
are some small comments:
- It would be nice if QXmlSchema::load overloads were statics ("named ctors"):
- QXmlSchema schema;
- if ( !schema.load( ... ) )
+ const QXmlSchema schema = QXmlSchema::load( ... );
+ if ( !schema.isValid() )
I think you should strive to ban two-step initialisation in your APIs.
- QXmlStreamReader can use a QString as input. QXmlSchemaValidator doesn't.
-> since these two will probably often be used side-by-side, I think it'd be
prudent if they both took the same inputs. (Then again, QXmlStreamReader
taking QString is probably the mistake here)
Thanks,
Marc
--
Marc Mutz <[email protected]> | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
_______________________________________________
Qt4-preview-feedback mailing list
[email protected]
http://lists.trolltech.com/mailman/listinfo/qt4-preview-feedback
