Hi, On Wed, Jan 21, 2015 at 11:51:15AM -0800, Michaël Cadilhac wrote: > Hi there everyone; > > I started some refactoring of the codebase for layouts, to free Groups from > the burden of distinguishing between floating and nonfloating windows. > More on this later this week when I'll be somewhat convinced that I went > The Right Way about that. For the moment, I have two related questions > regarding the expected behavior of layouts' methods: > 1- focus_next, focus_previous seem to be designed to only return the next > client of the layout. However, Max calls focus() on the passed window if > it's not the current one. Which way is the expected one?
I think Max is the outlier here, and it should really just return the next focused window (group.py has an explicit call to focus things afterwards). > 2- Somehow, most layouts implement cmd_up and _down, although it's not > mandatory. Is there an expected semantics behind that, that would make it > abnormal for layouts to not implement them? In particular, some layouts > change the window order on _up and _down, while the others don't. I think those should mostly just mean "go to the next window, for whatever value of next makes sense for this layout". The fact that some layouts implement this by actually changing their own client list is probably just because most of the layouts were written by different people. Any efforts to synchronize this would be much appreciated :) > Thanks to dx on #qtile for pointing out that using the mailing list would > be more productive for my questions. As a side question, what is the > proper way to submit a patch around here? The list or Git? The bulk of our code is merged via pull requests on github. If you don't like github, we occasionally get kernel `git send-email` style patches to this list, and I'm happy to merge those as well. > Cheers and happy hacking, To you as well. Tycho > M. > > -- > You received this message because you are subscribed to the Google Groups > "qtile-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "qtile-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
