On Sat, Nov 29, 2014 at 10:57:51PM +0100, Milan Kocian wrote:
>  Negative value in output of ecommunities (and as numbers)
>  seems odd :-). This patch fixes it. And add minor formating
>  modification, better for big as numbers.

[...cut...]

> +++ b/bgpd/bgp_vty.c
> @@ -8302,7 +8302,7 @@ bgp_write_rsclient_summary (struct vty *vty, struct 
> peer *rsclient,
>  
>    vty_out (vty, "4 ");
>  
> -  vty_out (vty, "%11d ", rsclient->as);
> +  vty_out (vty, "%11u ", rsclient->as);

Hm.  A 4-byte ASN still only needs 10 characters... maybe the code is
from someone who does the volume knob on subwoofers ;D

>    rmname = ROUTE_MAP_EXPORT_NAME(&rsclient->filter[afi][safi]);
>    if ( rmname && strlen (rmname) > 13 )
> @@ -8347,7 +8347,7 @@ bgp_show_rsclient_summary (struct vty *vty, struct bgp 
> *bgp,
>    int count = 0;
>  
>    /* Header string for each address family. */
> -  static char header[] = "Neighbor        V    AS  Export-Policy  
> Import-Policy  Up/Down  State";
> +  static char header[] = "Neighbor        V         AS  Export-Policy  
> Import-Policy  Up/Down  State";

Hm, the non-rsclient code could use some formatting improvements too...
- can you update this to change both?


-David

_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to