On Fri, 2015-01-09 at 17:16 +0800, Lu Feng wrote: > Hi Joakim, > > On 1/8/15, Joakim Tjernlund <[email protected]> wrote: > > > > On Thu, 2015-01-08 at 17:55 +0800, Lu Feng wrote: > > > > > > My answers are inline: > > > > > > On 1/8/15, Joakim Tjernlund <[email protected]> wrote: > > > > > > > > I remember this one, I sent a patch long time ago which we even > > > > discussed > > > > :) > > > > See http://patchwork.quagga.net/patch/537/ > > > > > > > > Yours is a bit different though: > > > > 1) at least PtoP links needs the same as virtual links. > > > > > > Please refer to the function ospf_nbr_key(), only VL nbr has a special way > > > of > > > building the key. That is, there's no need to treat the ptp nbr specially. > > > > Yes now I remember. There is another patch from me that corrects this, > > remember > > http://patchwork.quagga.net/patch/964/ ? > > Better to include ptop now so it will work later on. > > > > I remember that patch, and I ever added comment on it pointing out the > shortage of the patch. I'll not ack't it until you fix the issue. ;)
That won't happen, I am far behind master. This doesn't change that your patch should rebuild nbr for both virtual and ptop links. Anyhow, I won't argue this anymore Jocke _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
