On Thu, Jan 22, 2015 at 08:55:47PM +0000, Nambiar, Amritha wrote:
> --- a/isisd/isis_pdu.c
> 
> +++ b/isisd/isis_pdu.c
> 
> @@ -566,6 +566,14 @@ process_p2p_hello (struct isis_circuit *circuit)
> 
>     * the circuit
> 
>     */
> 
>    adj = circuit->u.p2p.neighbor;
> 
> +  /* If an adjacency exists, check it is with the source of the hello 
> packets */
> 
> +  if (adj){
> 
> +        if (memcmp(hdr->source_id, adj->sysid, ISIS_SYS_ID_LEN)){
> 
> +                zlog_debug("hello source and adjacency do not match, set adj 
> down\n");
> 
> +                isis_adj_state_change (adj, ISIS_ADJ_DOWN, "adj do not exist 
> anymore");
> 
> +                return 0;
> 
> +        }
> 
> +  }
> 
>   if (!adj || adj->level != hdr->circuit_t)
> 
>      {
> 
>        if (!adj)
> 
> 
> Please review and comment.

Your patch got broken by your e-mail client.  While we can fudge this,
this makes processing the patch significantly harder.

The best way to submit patches is to use git, commit your change locally
and use "git send-email".  If that doesn't work, "git format-patch" is
second best.  If using git is not possible, try to configure your e-mail
client for text-only mail, disable word wrapping, and paste the patch.
You can also add it as attachment, but always also paste it in the main
e-mail text body.

Cheers,


-David

_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to