On Tue, Feb 10, 2015 at 09:16:49AM -0500, Greg Troxel wrote: > David Lamparter <[email protected]> writes: > > Building with IPv6 disabled tends to break rather often and sprinkles > > ugly #ifdefs around the code. All that only to support systems where > > the C library doesn't have IPv6 capability. > > > > The year now being 2015, if this is a problem the thing to fix is the C > > library. > > > > The implication of this patch is that future patches need not care about > > HAVE_IPV6 = 0 and may remove ifdefs gratuitously. This patch doesn't > > remove these ifdefs to not create unneccessary churn. > > > > Signed-off-by: David Lamparter <[email protected]> > > That is an interesting proposal, but I think this one needs a bit more > thought.
I would've appreciated these comments 5 months ago when Paul posted his "require IPv6 API built-time support" patches... that should really have been ample time to voice concerns. > I suppose this is different from choosing to build only the v4 protocol > daemons. pkgsrc does have an inet6 option (on by default of course) to > cause packages not to do v6. > > I will ask the netbsd folks; netbsd of course has had v6 for a really > long time, more than 15 years, but some of them may have some useful > opinions. The matter at hand is simply that --disable-ipv6 in the build has repeatedly been broken before without anyone noticing, and making it work requires ugly #ifdef blocks. And all that is to support the case of a *libc* without IPv6 support (symbols & structs). Runtime / Kernel no-IPv6 is a different story. If disabling inet6 on NetBSD builds a libc without IPv6 support, thus causing Quagga to fail build with IPv6 enabled, I believe the best solution would be to disallow building Quagga on NetBSD systems without inet6. -David _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
