On Sun, Apr 19, 2015 at 06:23:50PM +0100, Paul Jakma wrote: > On Sun, 19 Apr 2015, David Lamparter wrote: > > On Fri, Apr 17, 2015 at 06:02:37PM +0100, Paul Jakma wrote: > >> Nice. > >> > >> Just one question. The s/CMD_/CMDS_/ in the macro names seems to just be > >> churn? Presumably to help catch uses while developing? If just churn, > >> maybe undo it? > > > > It was intentional to make the break in usage obvious. Maybe we should > > move it from command.h to .c altogether, it's not used anywhere else... > > (or even kill the macros, each of them has only one place of usage left) > > I'd be on for removal at use in Quagga. Though, maybe we should leave them > in the header and wrap them in the deprecated thing?
Removed CMDS_* (if this is used anywhere externally I'll eat a hat.) and applied. _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
