On Tue, 5 May 2015, David Lamparter wrote:

On Mon, Apr 27, 2015 at 04:36:10PM +0100, Paul Jakma wrote:
@@ -613,19 +613,20 @@ bgp_write_packet (struct peer *peer)
              {
                if (CHECK_FLAG (adv->binfo->peer->cap, PEER_CAP_RESTART_RCV)
                    && CHECK_FLAG (adv->binfo->peer->cap, PEER_CAP_RESTART_ADV)
-                   && ! (CHECK_FLAG (adv->binfo->peer->cap,
-                                      PEER_CAP_RESTART_BIT_RCV) &&
-                         CHECK_FLAG (adv->binfo->peer->cap,
-                                      PEER_CAP_RESTART_BIT_ADV))

The stale check:

-                   && ! CHECK_FLAG (adv->binfo->flags, BGP_INFO_STALE)

has disappeared.  This looks incorrect to me; stale routes are never
advertised.  Is this checked somewhere else?

Hmm... I don't remember now. Damn. Checking.

regards,
--
Paul Jakma      [email protected]  @pjakma Key ID: 64A2FF6A
Fortune:
Clones are people two.

_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to