On Thu, 14 May 2015, David Lamparter wrote:
On Fri, May 08, 2015 at 10:21:09PM +0100, Paul Jakma wrote:
To follow-up on an off-list discussion we had on GR, here's that tweak.
I gather you're also concerned about internal queueing and batching to
minimise CPU churn.
Indeed, I'd appreciate if we could work on making full GR out of
https://github.com/CumulusNetworks/quagga/commit/2ca83e1825158650546b82791834b87c2bb829fa
instead of doing this ;)
Hmm, do you perhaps mean this one?:
https://github.com/CumulusNetworks/quagga/commit/3e2a4c3513b1c896f92085bbb8f2bfb60c16f1e2
I had read that patch late last year.
That patch is somewhat orthogonal to what this patch-set is doing. The GR
patches I posted are fixing external-protocol related things. The cumulus
update-delay patch doesn't touch that at all, its addressing internal
issues.
It does add tracking of EoRs globally, and the external-protocol flags
could/should be updated, but it doesn't do that either.
This should indeed fix the issue I pointed out on IRC, however this
leaves another issue (if I'm brain-executing the code correctly):
If we start up with N peers (i.e. PEER_STATUS_GR_SEND_R_BIT), and one of
them is down/unreachable/plain doesn't exist anymore, we will forever
stay in GR=1 status, since bgp_update_all_eor_recvd includes that peer
and thus will never be true.
Only for that peer. The flag is peer-specific, it can't affect any other
peer. bgp_update_all_eor_recvd touches only peer-specific state.
Worse yet, the admin can't do anything about it, because deleting the
peer (after the other N-1 have already finished & sent their EoR) will
not re-trigger the all_eor_recvd check; thus we'll stay in GR=1 until
some other peer happens to send an EoR.
I don't follow how that's possible? R=1 flag state is peer-specific?
[Unless I misread the code and above description doesn't match the code:
NAK on all patches in this thread.]
I think you've misread the code maybe? Also, the update-delay stuff is
mostly unrelated, other than that it introduces a global tally of received
EoRs. If the update-delay patch is a reason to NACK my patches, then
something definitely has been misunderstood somewhere.
regards,
--
Paul Jakma [email protected] @pjakma Key ID: 64A2FF6A
Fortune:
Freedom's just another word for nothing left to lose.
-- Kris Kristofferson, "Me and Bobby McGee"
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
