Hi,

This cleans up a bit how {sockunion,prefix}2str work so that
they can be used for logging nicely. This also shows the power
of using properly the generic prefix function and zebra_vty's
ip/ipv6 "show route" code is unified. As total 200+ lines are
removed.

If this looks appropriate way to proceed, I can probably follow
up with similar patches for the other daemons too.

http://git.alpinelinux.org/cgit/tteras/quagga/log/?h=nhrp
is updated and rebased now on top of these. I'll clean up nhrpd
code after a while to take advantage of the above cleanups.

Thanks,
Timo

Timo Teräs (4):
  lib: make sockunion2str safer to use
  lib: make prefix2str simpler to use, and use it in zclient
  zebra/vty: use prefix2str and unify show ip/ipv6 route code
  zebra: use prefix2str for logging where possible

 lib/prefix.c          |   7 +-
 lib/prefix.h          |   5 +-
 lib/sockunion.c       |  17 ++-
 lib/zclient.c         |   6 +-
 zebra/interface.c     |   5 +-
 zebra/ioctl_solaris.c |  16 +-
 zebra/irdp_main.c     |   6 +-
 zebra/kernel_socket.c |  68 +++------
 zebra/redistribute.c  |  16 +-
 zebra/rt_netlink.c    |  35 ++---
 zebra/rt_socket.c     |  20 ++-
 zebra/rtadv.c         |   8 +-
 zebra/zebra_fpm.c     |   7 +-
 zebra/zebra_rib.c     |  80 +++++-----
 zebra/zebra_vty.c     | 412 ++++++++++++++------------------------------------
 15 files changed, 244 insertions(+), 464 deletions(-)

-- 
2.4.1


_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to