Donald,

Current zebra_vty.c 'show ip mroute' is unusual in the sense it displays a
*unicast* routing table -- used for multicast RPF lookups.
Usually "show ip mroute" queries the actual multicast table (the one
mapping multicast groups to OIL).
It's not a harmful thing, but it's a bit unexpected.

Everton


On Wed, May 27, 2015 at 10:23 AM, Donald Sharp <[email protected]>
wrote:

> I intend to do this:
>
> Leave the zebra_vty.c 'show ip mroute' command alone.  There is a slim
> chance that someone has this aliased and their scripts should be expected
> to work.
>
> For pimd/pim_cmd.c: modify 'show ip mroute' to 'show ip mroute pim'
>
> I'll submit a patch in a day or so.
>
> donald
>
> On Mon, May 25, 2015 at 12:17 AM, Everton Marques <
> [email protected]> wrote:
>
>> Donald,
>>
>> In zebra_vty.c,please notice there is "show ip rpf" lying as a dup for
>> "show ip mroute".
>> It's something I messed up and failed to clean.
>> If you choose to remove "show ip mroute", its functionality will remain
>> under "show ip rpf".
>>
>> Everton
>>
>>
>> On Sun, May 24, 2015 at 12:49 AM, Balaji G <[email protected]> wrote:
>>
>>> Hi Donald
>>>
>>> I had added the command in zebra_vty.c to dump the mbgp routing table in
>>> RTM. I should have renamed it to show IP route mbgp or something else but
>>> we could remove this command as I believe Cisco also does not show the mbgp
>>> routing table. Morever show ip mroute is the apt command for displaying
>>> mcast routing table.If that be the case I can send a patch for it to be
>>> removed
>>>
>>> Thanks
>>>   Balaji
>>> On May 24, 2015 6:17 AM, "Donald Sharp" <[email protected]>
>>> wrote:
>>>
>>>> In pim_cmd.c we have:
>>>>
>>>> DEFUN (show_ip_mroute,
>>>>        show_ip_mroute_cmd,
>>>>        "show ip mroute",
>>>>        SHOW_STR
>>>>        IP_STR
>>>>        MROUTE_STR)
>>>>
>>>> In zebra_vty.c we have:
>>>>
>>>> DEFUN (show_ip_mroute,
>>>>        show_ip_mroute_cmd,
>>>>        "show ip mroute",
>>>>        SHOW_STR
>>>>        IP_STR
>>>>        "IP Multicast routing table\n")
>>>>
>>>> Both of these commands display radically different information.
>>>>
>>>> When we parse the files( via extract.pl ) for compiling vtysh, both of
>>>> these commands conflict due to the same name and the pim_cmd.c file wins
>>>> the resolution.  Before I send a patch in to address this, what should be
>>>> the correct rename?  I suggest 'show ip mroute pim' for pim_cmd.c and leave
>>>> 'show ip mroute' for zebra_vty.c.  Do people have an opinion?
>>>>
>>>> donald
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Quagga-dev mailing list
>>>> [email protected]
>>>> https://lists.quagga.net/mailman/listinfo/quagga-dev
>>>>
>>>>
>>> _______________________________________________
>>> Quagga-dev mailing list
>>> [email protected]
>>> https://lists.quagga.net/mailman/listinfo/quagga-dev
>>>
>>>
>>
>
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to