On Tue, 2015-06-09 at 14:42 -0700, Martin Winter wrote:
> A few things I’ve noticed:
>
> 1) “with_ipv6” is default (at least since 0.99.24) and no longer
> configurable. I don’t think it can be disabled.
>
> 2) Would love if you add the FPM as an option for the configure
> (I would prefer as default, but some might have other opinions).
> This would require the “—enable-fpm” and “--enable-tcp-zebra”
> configure options together)
>
> 3) You didn’t update the changelog at the end of the spec file.
>
> 4) I always wonder if we shouldn’t install (empty) config files
> for bgpd, ospfd, (and all the other daemons) so they can be started
> if needed. The existing packages for RedHat (and most other Distro’s)
> seems to think it’s not needed and everyone would do it by hand…
> You seem to be installing the file for zebra (zebra.conf) but not
> the others.
You're giving me more credit than I deserve. While #3 was an oversight
on my part (I've lost the habit on using inline logs thanks to git), I
never considered or touched any of the other issues. I simply wanted to
resurrect the ability to generate RPMs for Quagga.
The configuration file question is an interesting one. I would imagine
that, for software as dependent upon configuration as this is, requiring
someone to "touch" configuration files before startup isn't
unreasonable.
This doesn't seem to be the norm, though. I'm thinking of bind, for
example, another configuration-heavy tool with which I've been working
recently. It does deliver a default configuration.
Is there some reasonable default configuration for the daemons other
than zebra that would be the analog of bind's "caching resolver"?
If I had to guess at the thinking of whomever chose to provide only one
of several configuration files, I'd say that a zebra.conf is included
because any quagga installation will require one. However, only an
installation using (for example) bgp will require a bgpd.conf.
- Andrew
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
