>From reading David's Comments, this patch looks like Balaji addressed the concerns. Is there anything else that needs to be done here?
donald On Sat, May 16, 2015 at 1:42 PM, Balaji.G <[email protected]> wrote: > This patch addresses David's comments and contains: > > 1.Addition of show ip bgp dampening command tree > 2.Addition of show ip bgp dampening parameters to display BGP dampening > parameters. > > Signed-off-by: Balaji.G <[email protected]> > --- > bgpd/bgp_route.c | 136 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 136 insertions(+) > > diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c > index 34cb7c0..438fb0c 100644 > --- a/bgpd/bgp_route.c > +++ b/bgpd/bgp_route.c > @@ -7169,6 +7169,17 @@ DEFUN (show_ip_bgp_flap_regexp, > bgp_show_type_flap_regexp); > } > > +ALIAS (show_ip_bgp_flap_regexp, > + show_ip_bgp_damp_flap_regexp_cmd, > + "show ip bgp dampening flap-statistics regexp .LINE", > + SHOW_STR > + IP_STR > + BGP_STR > + "Display detailed information about dampening\n" > + "Display flap statistics of routes\n" > + "Display routes matching the AS path regular expression\n" > + "A regular-expression to match the BGP AS paths\n") > + > DEFUN (show_ip_bgp_ipv4_regexp, > show_ip_bgp_ipv4_regexp_cmd, > "show ip bgp ipv4 (unicast|multicast) regexp .LINE", > @@ -7284,6 +7295,17 @@ DEFUN (show_ip_bgp_flap_prefix_list, > bgp_show_type_flap_prefix_list); > } > > +ALIAS (show_ip_bgp_flap_prefix_list, > + show_ip_bgp_damp_flap_prefix_list_cmd, > + "show ip bgp dampening flap-statistics prefix-list WORD", > + SHOW_STR > + IP_STR > + BGP_STR > + "Display detailed information about dampening\n" > + "Display flap statistics of routes\n" > + "Display routes conforming to the prefix-list\n" > + "IP prefix-list name\n") > + > DEFUN (show_ip_bgp_ipv4_prefix_list, > show_ip_bgp_ipv4_prefix_list_cmd, > "show ip bgp ipv4 (unicast|multicast) prefix-list WORD", > @@ -7398,6 +7420,17 @@ DEFUN (show_ip_bgp_flap_filter_list, > bgp_show_type_flap_filter_list); > } > > +ALIAS (show_ip_bgp_flap_filter_list, > + show_ip_bgp_damp_flap_filter_list_cmd, > + "show ip bgp dampening flap-statistics filter-list WORD", > + SHOW_STR > + IP_STR > + BGP_STR > + "Display detailed information about dampening\n" > + "Display flap statistics of routes\n" > + "Display routes conforming to the filter-list\n" > + "Regular expression access list name\n") > + > DEFUN (show_ip_bgp_ipv4_filter_list, > show_ip_bgp_ipv4_filter_list_cmd, > "show ip bgp ipv4 (unicast|multicast) filter-list WORD", > @@ -7469,6 +7502,18 @@ DEFUN (show_ipv6_mbgp_filter_list, > } > #endif /* HAVE_IPV6 */ > > +DEFUN (show_ip_bgp_dampening_info, > + show_ip_bgp_dampening_params_cmd, > + "show ip bgp dampening parameters", > + SHOW_STR > + IP_STR > + BGP_STR > + "Display detailed information about dampening\n" > + "Display detail of configured dampening parameters\n") > +{ > + return bgp_show_dampening_parameters (vty, AFI_IP, SAFI_UNICAST); > +} > + > static int > bgp_show_route_map (struct vty *vty, const char *rmap_str, afi_t afi, > safi_t safi, enum bgp_show_type type) > @@ -7513,6 +7558,17 @@ DEFUN (show_ip_bgp_flap_route_map, > bgp_show_type_flap_route_map); > } > > +ALIAS (show_ip_bgp_flap_route_map, > + show_ip_bgp_damp_flap_route_map_cmd, > + "show ip bgp dampening flap-statistics route-map WORD", > + SHOW_STR > + IP_STR > + BGP_STR > + "Display detailed information about dampening\n" > + "Display flap statistics of routes\n" > + "Display routes matching the route-map\n" > + "A route-map to match on\n") > + > DEFUN (show_ip_bgp_ipv4_route_map, > show_ip_bgp_ipv4_route_map_cmd, > "show ip bgp ipv4 (unicast|multicast) route-map WORD", > @@ -7579,6 +7635,16 @@ DEFUN (show_ip_bgp_flap_cidr_only, > bgp_show_type_flap_cidr_only, NULL); > } > > +ALIAS (show_ip_bgp_flap_cidr_only, > + show_ip_bgp_damp_flap_cidr_only_cmd, > + "show ip bgp dampening flap-statistics cidr-only", > + SHOW_STR > + IP_STR > + BGP_STR > + "Display detailed information about dampening\n" > + "Display flap statistics of routes\n" > + "Display only routes with non-natural netmasks\n") > + > DEFUN (show_ip_bgp_ipv4_cidr_only, > show_ip_bgp_ipv4_cidr_only_cmd, > "show ip bgp ipv4 (unicast|multicast) cidr-only", > @@ -9062,6 +9128,17 @@ DEFUN (show_ip_bgp_flap_prefix_longer, > bgp_show_type_flap_prefix_longer); > } > > +ALIAS (show_ip_bgp_flap_prefix_longer, > + show_ip_bgp_damp_flap_prefix_longer_cmd, > + "show ip bgp dampening flap-statistics A.B.C.D/M longer-prefixes", > + SHOW_STR > + IP_STR > + BGP_STR > + "Display detailed information about dampening\n" > + "Display flap statistics of routes\n" > + "IP prefix <network>/<length>, e.g., 35.0.0.0/8\n" > + "Display route and more specific routes\n") > + > DEFUN (show_ip_bgp_ipv4_prefix_longer, > show_ip_bgp_ipv4_prefix_longer_cmd, > "show ip bgp ipv4 (unicast|multicast) A.B.C.D/M longer-prefixes", > @@ -9095,6 +9172,16 @@ DEFUN (show_ip_bgp_flap_address, > bgp_show_type_flap_address); > } > > +ALIAS (show_ip_bgp_flap_address, > + show_ip_bgp_damp_flap_address_cmd, > + "show ip bgp dampening flap-statistics A.B.C.D", > + SHOW_STR > + IP_STR > + BGP_STR > + "Display detailed information about dampening\n" > + "Display flap statistics of routes\n" > + "Network in the BGP routing table to display\n") > + > DEFUN (show_ip_bgp_flap_prefix, > show_ip_bgp_flap_prefix_cmd, > "show ip bgp flap-statistics A.B.C.D/M", > @@ -9107,6 +9194,17 @@ DEFUN (show_ip_bgp_flap_prefix, > return bgp_show_prefix_longer (vty, argv[0], AFI_IP, SAFI_UNICAST, > bgp_show_type_flap_prefix); > } > + > +ALIAS (show_ip_bgp_flap_prefix, > + show_ip_bgp_damp_flap_prefix_cmd, > + "show ip bgp dampening flap-statistics A.B.C.D/M", > + SHOW_STR > + IP_STR > + BGP_STR > + "Display detailed information about dampening\n" > + "Display flap statistics of routes\n" > + "IP prefix <network>/<length>, e.g., 35.0.0.0/8\n") > + > #ifdef HAVE_IPV6 > DEFUN (show_bgp_prefix_longer, > show_bgp_prefix_longer_cmd, > @@ -11981,6 +12079,15 @@ DEFUN (show_ip_bgp_dampened_paths, > NULL); > } > > +ALIAS (show_ip_bgp_dampened_paths, > + show_ip_bgp_damp_dampened_paths_cmd, > + "show ip bgp dampening dampened-paths", > + SHOW_STR > + IP_STR > + BGP_STR > + "Display detailed information about dampening\n" > + "Display paths suppressed due to dampening\n") > + > DEFUN (show_ip_bgp_flap_statistics, > show_ip_bgp_flap_statistics_cmd, > "show ip bgp flap-statistics", > @@ -11993,6 +12100,15 @@ DEFUN (show_ip_bgp_flap_statistics, > bgp_show_type_flap_statistics, NULL); > } > > +ALIAS (show_ip_bgp_flap_statistics, > + show_ip_bgp_damp_flap_statistics_cmd, > + "show ip bgp dampening flap-statistics", > + SHOW_STR > + IP_STR > + BGP_STR > + "Display detailed information about dampening\n" > + "Display flap statistics of routes\n") > + > /* Display specified route of BGP table. */ > static int > bgp_clear_damp_route (struct vty *vty, const char *view_name, > @@ -12506,16 +12622,25 @@ bgp_route_init (void) > install_element (VIEW_NODE, &show_ip_bgp_ipv4_neighbor_routes_cmd); > install_element (VIEW_NODE, > &show_ip_bgp_neighbor_received_prefix_filter_cmd); > install_element (VIEW_NODE, > &show_ip_bgp_ipv4_neighbor_received_prefix_filter_cmd); > + install_element (VIEW_NODE, &show_ip_bgp_dampening_params_cmd); > install_element (VIEW_NODE, &show_ip_bgp_dampened_paths_cmd); > + install_element (VIEW_NODE, &show_ip_bgp_damp_dampened_paths_cmd); > install_element (VIEW_NODE, &show_ip_bgp_flap_statistics_cmd); > + install_element (VIEW_NODE, &show_ip_bgp_damp_flap_statistics_cmd); > install_element (VIEW_NODE, &show_ip_bgp_flap_address_cmd); > + install_element (VIEW_NODE, &show_ip_bgp_damp_flap_address_cmd); > install_element (VIEW_NODE, &show_ip_bgp_flap_prefix_cmd); > install_element (VIEW_NODE, &show_ip_bgp_flap_cidr_only_cmd); > + install_element (VIEW_NODE, &show_ip_bgp_damp_flap_cidr_only_cmd); > install_element (VIEW_NODE, &show_ip_bgp_flap_regexp_cmd); > install_element (VIEW_NODE, &show_ip_bgp_flap_filter_list_cmd); > + install_element (VIEW_NODE, &show_ip_bgp_damp_flap_filter_list_cmd); > install_element (VIEW_NODE, &show_ip_bgp_flap_prefix_list_cmd); > + install_element (VIEW_NODE, &show_ip_bgp_damp_flap_prefix_list_cmd); > install_element (VIEW_NODE, &show_ip_bgp_flap_prefix_longer_cmd); > + install_element (VIEW_NODE, &show_ip_bgp_damp_flap_prefix_longer_cmd); > install_element (VIEW_NODE, &show_ip_bgp_flap_route_map_cmd); > + install_element (VIEW_NODE, &show_ip_bgp_damp_flap_route_map_cmd); > install_element (VIEW_NODE, &show_ip_bgp_neighbor_flap_cmd); > install_element (VIEW_NODE, &show_ip_bgp_neighbor_damp_cmd); > install_element (VIEW_NODE, &show_ip_bgp_rsclient_cmd); > @@ -12639,16 +12764,27 @@ bgp_route_init (void) > install_element (ENABLE_NODE, &show_ip_bgp_ipv4_neighbor_routes_cmd); > install_element (ENABLE_NODE, > &show_ip_bgp_neighbor_received_prefix_filter_cmd); > install_element (ENABLE_NODE, > &show_ip_bgp_ipv4_neighbor_received_prefix_filter_cmd); > + install_element (ENABLE_NODE, &show_ip_bgp_dampening_params_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_dampened_paths_cmd); > + install_element (ENABLE_NODE, &show_ip_bgp_damp_dampened_paths_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_flap_statistics_cmd); > + install_element (ENABLE_NODE, &show_ip_bgp_damp_flap_statistics_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_flap_address_cmd); > + install_element (ENABLE_NODE, &show_ip_bgp_damp_flap_address_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_flap_prefix_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_flap_cidr_only_cmd); > + install_element (ENABLE_NODE, &show_ip_bgp_damp_flap_cidr_only_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_flap_regexp_cmd); > + install_element (ENABLE_NODE, &show_ip_bgp_damp_flap_regexp_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_flap_filter_list_cmd); > + install_element (ENABLE_NODE, &show_ip_bgp_damp_flap_filter_list_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_flap_prefix_list_cmd); > + install_element (ENABLE_NODE, &show_ip_bgp_damp_flap_prefix_list_cmd); > + install_element (ENABLE_NODE, &show_ip_bgp_damp_flap_prefix_list_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_flap_prefix_longer_cmd); > + install_element (ENABLE_NODE, &show_ip_bgp_damp_flap_prefix_longer_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_flap_route_map_cmd); > + install_element (ENABLE_NODE, &show_ip_bgp_damp_flap_route_map_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_neighbor_flap_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_neighbor_damp_cmd); > install_element (ENABLE_NODE, &show_ip_bgp_rsclient_cmd); > -- > 1.9.1 > > > _______________________________________________ > Quagga-dev mailing list > [email protected] > https://lists.quagga.net/mailman/listinfo/quagga-dev >
_______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
