The quagga world is a bit low on reviewing resources. To make this easier to review, please:
avoid adding extraneous files
avoid gratuitous changes to whitespace
publish git commits, with commit messages, rather than a diff
ensure that the new code is commented, and that the commit message
explains what's changing
explain how much it has been tested
eg.
-#define BGP_INFO_COUNTED (1 << 10)
+#define BGP_INFO_COUNTED (1 << 10)
looks like a wrong change.
This hunk also looks wrong:
--- a/lib/workqueue.h
+++ b/lib/workqueue.h
@@ -69,8 +69,8 @@
* First argument is the workqueue queue.
* Second argument is the item data
*/
- wq_item_status (*workfunc) (struct work_queue *, void *);
+ wq_item_status (*workfunc) (struct work_queue *, void *);
/* error handling function, optional */
void (*errorfunc) (struct work_queue *, struct work_queue_item *);
As it stands, these problems prevent the patch from being integrated.
pgp2fIkuuhgRj.pgp
Description: PGP signature
_______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
