Timo - nhrp is turned on by default. Typically this is the reverse for new daemons from what I can tell( Feel free to correct me if I am wrong here ).
lib/sigevent.c - Any particular reason this code was changed? Especially since you #if 0'ed it, if this was intentional, please just remove the code. I suspect this was a testing change? nhrpd/list.h - This really belongs in lib, and in fact quagga already has link list functionality. Did I catch the tail end of this discussion on the quagga irc channel a few weeks back between you and Paul? What was the conclusion there? From a very quick glance the two implementations look orthogonal enough that they could be both put in lib and then work could be done to move to the future( whatever the future is ). nhrpd/netlink.[ch] - Do you forsee a future where this netlink code will be used elsewhere? If so then shouldn't this interface be in zebra? BTW, not just for this code, but this comment also goes for the setsockopt interface in pimd for multicast routes. In all honesty, it's 7k lines of code. It's too big to review, this sure does look like a step in the right direction though, so it gets my ACK :) donald On Wed, Jul 1, 2015 at 4:54 AM, Timo Teras <[email protected]> wrote: > Hi, > > My NHRP work is starting to be in relatively stable state. There has > not been much changes in past few weeks, but I've been actively testing > it. I do have few follow up commits coming later on but nothing > critical. > > Could you take a look at: > http://git.alpinelinux.org/cgit/user/tteras/quagga/?h=nhrp > > I'd appreciate to get some feedback what it'd get to have this merged > upstream. > > It also seems there has not been git commits in few weeks in > quagga.git? Are the maintainers on vacation? > > I'd hope to have the nexthop-tracking patches merged in sometime soon. > I remember equinox promising to take a look at them. Any progress on > that? > > Thanks, > Timo > > > _______________________________________________ > Quagga-dev mailing list > [email protected] > https://lists.quagga.net/mailman/listinfo/quagga-dev >
_______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
