+1
When a FIB manager is the author/owner of a route, it must be trusted.
Since the kernels (BSD, Linux) do not provide any means(*) from
preventing 3rd parties from removing such routes, let's add them again
like you are doing with this patch.
However, since it changes some behaviours, I feel it requires a argv +
CLI command in order to disable this behaviour. I agree that your
proposal should be the default behavior.
About the patch:
- the git log is not good enough, your email is better
- zlog_debug ("Zebra route %s/%d was deleted by others from kernel",
-> it should be a warning, not a debug function to be displayed anytimes
it happens.
- INET6 is missing.
Best regards,
On 30/07/2015 14:37, Donald Sharp wrote:
In a private discussion with David Lamparter, we discussed this patch:
https://github.com/CumulusNetworks/quagga/commit/8b27eb162a9048498f2f87e4ae60b9a6ae62941b
This patch changes the behavior of Quagga to reinstall routes, that were
sourced from Quagga, back into the kernel if a route delete is
received. David felt that this behavior was enough of a change that it
should be brought to the list for discussion/decision. The whole crux
of the decision revolves around the question 'Who is the source of truth
for routes?'. We've written this patch because we believe that the
answer to this question is that Quagga is the source of truth of routes
if it is being run.
Finally David also had some questions about how this could be done on
BSD as well.
thoughts?
thanks!
donald
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
