Hi, On Wed, 29 Jul 2015 22:23:54 +0100 (BST) Paul Jakma <[email protected]> wrote:
> Catching up. Round 1 of proposed patches: Nice! Good work. > Next round, once above is settled/closed, the list can consider and > review: > > - NHRP As prerequisite the Cumulus tree next-hop-tracking should get in. I did have to revert one patch: "A valid BGP nexthop is flagged as invalid" which considers recursive routes as valid nexthops - but that's not how zebra works when calculating FIB candidates. Perhaps this is fixed somehow else in cumulus tree on later commits? Additionally, the atomic FIB updates / FIB override patches to zebra should probably be reviewed separately. I already have some fixup commits to these as well in my tree. I also added new patch to support setting MTU on per route basis. This would probably go on the same zebra commit series. After that the bulk of nhrp is isolated to nhrpd/ and probably can be committed as big chunk, unless we want to move some of the things to lib/. I'm currently doing final bug fixing, and few more features to nhrpd. But I can probably start working on the to-be-merged commits in few weeks time. Thanks! - Timo _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
