Is there someone who can take a look on my change? Regards, Sergii
Sergii Vystoropskyi Software Developer Engineer, Systems and Network Engineering, Amazon Web Services Mobile: 206-604-3768 [Description: cid:[email protected]] <http://aws.amazon.com/> From: Vystoropskyi, Sergii Sent: Saturday, August 22, 2015 12:00 AM To: 'Paul Jakma' Cc: '[email protected]' Subject: RE: [quagga-dev 12926] [PATCH] ospfd: Fix for 'no' + 'debug command' does not disable 'debug command' Hi Paul, Could you please review my patch? So I can suggest one more ☺ Regards, Sergii Sergii Vystoropskyi Software Developer Engineer, Systems and Network Engineering, Amazon Web Services Mobile: 206-604-3768 [Description: cid:[email protected]] <http://aws.amazon.com/> From: Vystoropskyi, Sergii Sent: Friday, August 21, 2015 11:06 AM To: 'Donald Sharp' Cc: [email protected]<mailto:[email protected]> Subject: RE: [quagga-dev 12926] [PATCH] ospfd: Fix for 'no' + 'debug command' does not disable 'debug command' Thanks Donald. Is there someone who can review my change, to be done with this patch and move to the next one ☺ Sergii Vystoropskyi Software Developer Engineer, Systems and Network Engineering, Amazon Web Services Mobile: 206-604-3768 [Description: cid:[email protected]] <http://aws.amazon.com/> From: Donald Sharp [mailto:[email protected]] Sent: Friday, August 21, 2015 5:39 AM To: Vystoropskyi, Sergii Cc: [email protected]<mailto:[email protected]> Subject: Re: [quagga-dev 12926] [PATCH] ospfd: Fix for 'no' + 'debug command' does not disable 'debug command' Yes a different CR would be fine. As for this patch. I think it's good enough to go in. I do not have commit approval though. donald On Fri, Aug 21, 2015 at 6:38 AM, Vystoropskyi, Sergii <[email protected]<mailto:[email protected]>> wrote: Sorry for a long response. Can I do that with a different CR? If answer is yes does it mean that this patch is approved ? Sergii Vystoropskyi Software Developer Engineer, Systems and Network Engineering, Amazon Web Services Mobile: 206-604-3768<tel:206-604-3768> [Description: cid:[email protected]] <http://aws.amazon.com/> From: Donald Sharp [mailto:[email protected]<mailto:[email protected]>] Sent: Monday, August 17, 2015 5:23 AM To: Vystoropskyi, Sergii Cc: [email protected]<mailto:[email protected]> Subject: Re: [quagga-dev 12926] [PATCH] ospfd: Fix for 'no' + 'debug command' does not disable 'debug command' As that you are in there. Could you take a few seconds and figure out if the OSPF_DEBUG_RECV and OSPF_DEBUG_SEND paths in the no function are correct as well? Sure seems odd that the turn on's for them don't have DETAIL while the turn off's for them do? I realize that it's not necessarily the code you are looking at here, but it might be worth taking a few seconds and sorting it out. Other than that I think it's a step in the right direction so it get's my ack. Acked-by: Donald Sharp <[email protected]<mailto:[email protected]>> On Sun, Aug 16, 2015 at 9:25 AM, Vystoropskyi, Sergii <[email protected]<mailto:[email protected]>> wrote: "no debug ospf packet all detail" does not cancel "debug ospf packet all detail" due to the code inconsistency in setting/unsetting debug flags. * ospf_dump.c: added missing flags. --- ospfd/ospf_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ospfd/ospf_dump.c b/ospfd/ospf_dump.c index 2e4e69d..ac93f1d 100644 --- a/ospfd/ospf_dump.c +++ b/ospfd/ospf_dump.c @@ -902,7 +902,7 @@ DEFUN (no_debug_ospf_packet, else if (strncmp (argv[1], "r", 1) == 0) flag = OSPF_DEBUG_RECV | OSPF_DEBUG_DETAIL; else if (strncmp (argv[1], "d", 1) == 0) - flag = OSPF_DEBUG_DETAIL; + flag = OSPF_DEBUG_SEND | OSPF_DEBUG_RECV | OSPF_DEBUG_DETAIL; } /* detail. */ -- 1.7.9.5 _______________________________________________ Quagga-dev mailing list [email protected]<mailto:[email protected]> https://lists.quagga.net/mailman/listinfo/quagga-dev
_______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
